Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI error for auto deref #160

Merged
merged 1 commit into from
Nov 15, 2022
Merged

fix: CI error for auto deref #160

merged 1 commit into from
Nov 15, 2022

Conversation

Xynnn007
Copy link
Member

Signed-off-by: Xynnn007 xynnn@linux.alibaba.com

Summary

This PR fixes the CI error

error: deref which would be done by auto-deref
Error:    --> src/fulcio/oauth.rs:104:13
    |
104 | /             &*format!(
105 | |                 "127.0.0.1:{}",
106 | |                 self.redirect_port.unwrap_or(DEFAULT_REDIRECT_PORT)
107 | |             ),
    | |_____________^
    |
    = note: `-D clippy::explicit-auto-deref` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
help: try this
    |
104 ~             &format!(
105 +                 "127.0.0.1:{}",
106 +                 self.redirect_port.unwrap_or(DEFAULT_REDIRECT_PORT)
107 ~             ),
    |

Release Note

Documentation

@Xynnn007
fix: CI error for auto deref
7885f6f 
Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@flavio flavio merged commit 57d276f into sigstore:main Nov 15, 2022
@Xynnn007 Xynnn007 deleted the fix-ci branch November 15, 2022 09:43
flavio added a commit to flavio/sigstore-rs that referenced this pull request Nov 24, 2022
@flavio
Tag v0.6.0
ee9fdbe 
Fixes
=====

* Fix typo in cosign/mod.rs doc comment by @danbev in sigstore#148
* Fix typo in KeyPair trait doc comment by @danbev in sigstore#149
* Update cached requirement from 0.39.0 to 0.40.0 by @dependabot in sigstore#154
* Fix typos in PublicKeyVerifier doc comments by @danbev in sigstore#155
* Fix: CI error for auto deref by @Xynnn007 in sigstore#160
* Fix typo and grammar in signature_layers.rs by @danbev in sigstore#161
* Remove unused imports in examples/rekor by @danbev in sigstore#162
* Update link to verification example by @danbev in sigstore#156
* Fix typos in from_encrypted_pem doc comments by @danbev in sigstore#164
* Fix typos in doc comments by @danbev in sigstore#163
* Update path to fulcio-cert in verify example by @danbev in sigstore#168

Enhancements
============

* Add getter functions for LogEntry fields by @lkatalin in sigstore#147
* Add TreeSize alias to Rekor by @avery-blanchard in sigstore#151
* Updates for parsing hashedrekord LogEntry by @lkatalin in sigstore#152
* Add certificate based verification by @flavio in sigstore#159
* Add support for OCI Image signing (spec v1.0) by @Xynnn007 in sigstore#158
Contributors
============

* Avery Blanchard (@avery-blanchardmade)
* Daniel Bevenius (@danbev)
* Flavio Castelli (@flavio)
* Lily Sturmann (@lkatalin)
* Xynnn (@Xynnn007)

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio flavio mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xynnn007 @flavio